<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112590/">http://git.reviewboard.kde.org/r/112590/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 8th, 2013, 4:28 p.m. MSK, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you didn't understand the existing code. At least in master the todo marker words are written out explicitly, the kcmodule support for named widgets is intentionally not used because the string from the field should apparently be split according to shell-rules and should then be put into a stringlist. Using the support for named widgets would break this as it would use a simple string to store the text entry.
Same goes for the completion detail setting, IIRC the kcmodule support for named widgets uses the text of the entry but it seems the code wants to rather use the index. I might be wrong on this one though.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm... I didn't think about shell-rules. Thanks!
Still, I don't think it reason enough not to use kcmodule's feature. Marker words can be split afterward in todoMarkerWords() function.
Also I forgot to mention that in ccconfig.kcfg "marker words" represented as StingList, but in GUI it's just a String. That's another reason why it didn't work before.
>>The kcmodule support for named widgets uses the text of the entry but it seems the code wants to rather use the index.
Thats exactly what I mentioned in FIXME note. And thats why I manually save/load settings for completion detail. </pre>
<br />
<p>- Vlas</p>
<br />
<p>On September 8th, 2013, 3:47 p.m. MSK, Vlas Puhov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Vlas Puhov.</div>
<p style="color: grey;"><i>Updated Sept. 8, 2013, 3:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CCPreferences class is written with use of KCModule, so all setting can be saved/loaded automatically. For that widget's names should start with kcfg_ prefix, but neither todoMarkerWords nor completionDetail had one, so this feature didn't work.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=324510">324510</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/completionsettings.h <span style="color: grey">(b3f28ce)</span></li>
<li>shell/completionsettings.cpp <span style="color: grey">(6b6adf6)</span></li>
<li>shell/settings/ccconfig.kcfg <span style="color: grey">(1bc89b1)</span></li>
<li>shell/settings/ccpreferences.h <span style="color: grey">(4ecf623)</span></li>
<li>shell/settings/ccpreferences.cpp <span style="color: grey">(0347fc6)</span></li>
<li>shell/settings/ccsettings.ui <span style="color: grey">(64d24e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112590/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>