[kdevelop] languages/cpp/cppduchain: Minor: Fix warnings

[Aleix Pol]

On Wed, Oct 16, 2013 at 7:02 PM, Milian Wolff <mail at milianw.de> wrote:

> On Wednesday 16 October 2013 07:30:06 Kevin Funk wrote:
> > Git commit c0235f2a2cfc2a559e92755bb5e467fc7582b266 by Kevin Funk.
> > Committed on 16/10/2013 at 07:28.
> > Pushed by kfunk into branch 'master'.
> >
> > Minor: Fix warnings
> >
> > M  +2    -0    languages/cpp/cppduchain/typeconversion.cpp
> > M  +0    -1    languages/cpp/cppduchain/typeutils.cpp
> >
> > http://commits.kde.org/kdevelop/c0235f2a2cfc2a559e92755bb5e467fc7582b266
> >
> > diff --git a/languages/cpp/cppduchain/typeconversion.cpp
> > b/languages/cpp/cppduchain/typeconversion.cpp index b7fc570..dd1f23b
> 100644
> > --- a/languages/cpp/cppduchain/typeconversion.cpp
> > +++ b/languages/cpp/cppduchain/typeconversion.cpp
> > @@ -610,6 +610,8 @@ bool TypeConversion::isAccessible(const
> > ClassMemberDeclaration* decl) {
> >
> >  ConversionRank TypeConversion::ellipsisConversion( AbstractType::Ptr
> from,
> > AbstractType::Ptr to ) {
> > +  Q_UNUSED(from);
> > +
>
> This should preferrably be fixed by cleanup up the function to not take the
> from argument at all anymore.
>
> While at it, make the to a const& argument.
>
> Any JJ takers?
> --
> Milian Wolff
> mail at milianw.de
> http://milianw.de
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kdevelop-devel
>

maybe we can make this (and other JJ) GCI tasks?

Aleix
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131017/3f82e375/attachment.html>