<div dir="ltr">On Wed, Oct 16, 2013 at 7:02 PM, Milian Wolff <span dir="ltr"><<a href="mailto:mail@milianw.de" target="_blank">mail@milianw.de</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div class="im">On Wednesday 16 October 2013 07:30:06 Kevin Funk wrote:<br>
> Git commit c0235f2a2cfc2a559e92755bb5e467fc7582b266 by Kevin Funk.<br>
> Committed on 16/10/2013 at 07:28.<br>
> Pushed by kfunk into branch 'master'.<br>
><br>
> Minor: Fix warnings<br>
><br>
> M  +2    -0    languages/cpp/cppduchain/typeconversion.cpp<br>
> M  +0    -1    languages/cpp/cppduchain/typeutils.cpp<br>
><br>
> <a href="http://commits.kde.org/kdevelop/c0235f2a2cfc2a559e92755bb5e467fc7582b266" target="_blank">http://commits.kde.org/kdevelop/c0235f2a2cfc2a559e92755bb5e467fc7582b266</a><br>
><br>
> diff --git a/languages/cpp/cppduchain/typeconversion.cpp<br>
> b/languages/cpp/cppduchain/typeconversion.cpp index b7fc570..dd1f23b 100644<br>
> --- a/languages/cpp/cppduchain/typeconversion.cpp<br>
> +++ b/languages/cpp/cppduchain/typeconversion.cpp<br>
> @@ -610,6 +610,8 @@ bool TypeConversion::isAccessible(const<br>
> ClassMemberDeclaration* decl) {<br>
><br>
>  ConversionRank TypeConversion::ellipsisConversion( AbstractType::Ptr from,<br>
> AbstractType::Ptr to ) {<br>
> +  Q_UNUSED(from);<br>
> +<br>
<br>
</div>This should preferrably be fixed by cleanup up the function to not take the<br>
from argument at all anymore.<br>
<br>
While at it, make the to a const& argument.<br>
<br>
Any JJ takers?<br>
<span class=""><font color="#888888">--<br>
Milian Wolff<br>
<a href="mailto:mail@milianw.de">mail@milianw.de</a><br>
<a href="http://milianw.de" target="_blank">http://milianw.de</a><br>
_______________________________________________<br>
KDevelop-devel mailing list<br>
<a href="mailto:KDevelop-devel@kde.org">KDevelop-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kdevelop-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kdevelop-devel</a><br>
</font></span></blockquote></div><br></div><div class="gmail_extra">maybe we can make this (and other JJ) GCI tasks?<div><br></div><div>Aleix</div></div></div>