Review Request 113030: Patch for Bug 319011 - Difficult to view full plugin description

Milian Wolff mail at milianw.de
Wed Oct 2 09:14:50 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113030/#review41098
-----------------------------------------------------------


Looks good, remove this one spurious line and then you can commit it. Do you have commit rights? If not, someone of us will handle it once you upload a fixed patch.


plugins/execute/executeplugin.cpp
<http://git.reviewboard.kde.org/r/113030/#comment30165>

    you can remove this line.


- Milian Wolff


On Oct. 2, 2013, 8:45 a.m., Meenakshi Khorana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113030/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 8:45 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> 
> Patch for Bug 319011 - Difficult to view full plugin description 
> 
> Have made changes to core plugins only but I have not made any changes to New Project Wizard and Project Manager View as i found their About to have relevant information. 
> 
> 
> Diffs
> -----
> 
>   plugins/classbrowser/classbrowserplugin.cpp 1212b63 
>   plugins/contextbrowser/contextbrowser.cpp 85e90b0 
>   plugins/dashboard/kdevprojectdashboard.cpp 7eb0816 
>   plugins/execute/executeplugin.cpp f3d4a8b 
>   plugins/filemanager/kdevfilemanagerplugin.cpp 04b4741 
>   plugins/filetemplates/filetemplatesplugin.cpp c34ab4a 
>   plugins/openwith/openwithplugin.cpp a64b08c 
>   plugins/quickopen/quickopenplugin.cpp 1779219 
> 
> Diff: http://git.reviewboard.kde.org/r/113030/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested successfully on my local machine. Kdevelop is showing full description in About of Plugins.
> 
> 
> Thanks,
> 
> Meenakshi Khorana
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131002/54f1473e/attachment.html>


More information about the KDevelop-devel mailing list