<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113030/">http://git.reviewboard.kde.org/r/113030/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, remove this one spurious line and then you can commit it. Do you have commit rights? If not, someone of us will handle it once you upload a fixed patch.</pre>
 <br />







<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/113030/diff/1/?file=193204#file193204line64" style="color: black; font-weight: bold; text-decoration: underline;">plugins/execute/executeplugin.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString ExecutePlugin::userIdToRunEntry = "User Id to Run";</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">K_EXPORT_PLUGIN</span><span class="p">(</span><span class="n">KDevExecuteFactory</span><span class="p">(</span><span class="n">KAboutData</span><span class="p">(</span><span class="s">"kdevexecute"</span><span class="p">,</span> <span class="s">"kdevexecute"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span><span class="s">"Execute support"</span><span class="p">),</span> <span class="s">"0.1"</span><span class="p">,</span> <span class="n">ki18n</span><span class="p">(</span><span class="s">"Allows running of native apps"</span><span class="p">),</span> <span class="n">KAboutData</span><span class="o">::</span><span class="n">License_GPL</span><span class="p">)))</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">//</span>K_EXPORT_PLUGIN(KDevExecuteFactory(KAboutData("kdevexecute", "kdevexecute", ki18n("Execute support"), "0.1", ki18n("Allows running of native apps"), KAboutData::License_GPL)))</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you can remove this line.</pre>
</div>
<br />



<p>- Milian Wolff</p>


<br />
<p>On October 2nd, 2013, 8:45 a.m. UTC, Meenakshi Khorana wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Meenakshi Khorana.</div>


<p style="color: grey;"><i>Updated Oct. 2, 2013, 8:45 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">
Patch for Bug 319011 - Difficult to view full plugin description 

Have made changes to core plugins only but I have not made any changes to New Project Wizard and Project Manager View as i found their About to have relevant information. </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and tested successfully on my local machine. Kdevelop is showing full description in About of Plugins.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/classbrowser/classbrowserplugin.cpp <span style="color: grey">(1212b63)</span></li>

 <li>plugins/contextbrowser/contextbrowser.cpp <span style="color: grey">(85e90b0)</span></li>

 <li>plugins/dashboard/kdevprojectdashboard.cpp <span style="color: grey">(7eb0816)</span></li>

 <li>plugins/execute/executeplugin.cpp <span style="color: grey">(f3d4a8b)</span></li>

 <li>plugins/filemanager/kdevfilemanagerplugin.cpp <span style="color: grey">(04b4741)</span></li>

 <li>plugins/filetemplates/filetemplatesplugin.cpp <span style="color: grey">(c34ab4a)</span></li>

 <li>plugins/openwith/openwithplugin.cpp <span style="color: grey">(a64b08c)</span></li>

 <li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(1779219)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113030/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>