Review Request 114164: environment settings: add ability to paste multiple items

[Kevin Funk]

> On Nov. 28, 2013, 1:50 p.m., Milian Wolff wrote:
> > shell/settings/environmentwidget.cpp, line 184
> > <http://git.reviewboard.kde.org/r/114164/diff/5/?file=220940#file220940line184>
> >
> >     maybe change this to i18n("Insert multiple line-separated environment variables in the format:
> >     <pre>VARIABLE1=VALUE1
> >     VARIABLE2=VALUE2
> >     ...</pre>"); ?

Note that this string is for KTextEdit::clickMessage, it's not a label above the KTextEdit. So I'd say it's not worth to have such a descriptive text here. (And <pre> doesn't make sense in there as well, I think)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114164/#review44695
-----------------------------------------------------------


On Nov. 28, 2013, 1:32 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114164/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 1:32 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> In case where she already had configured env in shell, let her simply copy paste that env to configuration instead of tediously filling items one by one.
> 
> Not sure about the icon chosen for button.
> 
> 
> Diffs
> -----
> 
>   shell/settings/environmentwidget.h b464a4b 
>   shell/settings/environmentwidget.cpp ace016a 
>   shell/settings/environmentwidget.ui 4140c98 
> 
> Diff: http://git.reviewboard.kde.org/r/114164/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131128/b938c14e/attachment.html>