Review Request 114164: environment settings: add ability to paste multiple items
Milian Wolff
mail at milianw.de
Thu Nov 28 13:50:18 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114164/#review44695
-----------------------------------------------------------
Ship it!
Ah yeah the screenshot looks good. One small nitpick then I'm OK with it.
shell/settings/environmentwidget.cpp
<http://git.reviewboard.kde.org/r/114164/#comment31921>
maybe change this to i18n("Insert multiple line-separated environment variables in the format:
<pre>VARIABLE1=VALUE1
VARIABLE2=VALUE2
...</pre>"); ?
- Milian Wolff
On Nov. 28, 2013, 1:32 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114164/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2013, 1:32 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> In case where she already had configured env in shell, let her simply copy paste that env to configuration instead of tediously filling items one by one.
>
> Not sure about the icon chosen for button.
>
>
> Diffs
> -----
>
> shell/settings/environmentwidget.h b464a4b
> shell/settings/environmentwidget.cpp ace016a
> shell/settings/environmentwidget.ui 4140c98
>
> Diff: http://git.reviewboard.kde.org/r/114164/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131128/9947a450/attachment.html>
More information about the KDevelop-devel
mailing list