Review Request 113967: Fix static QString initialization order issue

Andrea Scarpino scarpino at kde.org
Wed Nov 20 11:21:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113967/
-----------------------------------------------------------

(Updated Nov. 20, 2013, 12:21 p.m.)


Review request for KDevelop.


Changes
-------

Milian's fixes


Repository: kdev-xml


Description
-------

ATM kdev-xml crashes when you start KDevelop. The crash is at xmlcatalog/oasiscatalog.cpp:286
It tries to assign the value of the PreferPublic static attribute that has not been initialized yet.

Fix this by post-poning the CatalogManager initialization by moving it in the self() method.


Diffs (updated)
-----

  xmlcatalog/icatalogmanager.cpp ee79dbaec715d5b2323917ccdde3c48c8e07686a 

Diff: http://git.reviewboard.kde.org/r/113967/diff/


Testing
-------

Doesn't crash anymore


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131120/a5d8c236/attachment.html>


More information about the KDevelop-devel mailing list