Review Request 113967: Fix static QString initialization order issue

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113967/#review44033
-----------------------------------------------------------



xmlcatalog/icatalogmanager.cpp
<http://git.reviewboard.kde.org/r/113967/#comment31573>

    init to 0 here



xmlcatalog/icatalogmanager.cpp
<http://git.reviewboard.kde.org/r/113967/#comment31574>

    if (!instance) {
      ...
    }


- Milian Wolff


On Nov. 20, 2013, 10:51 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113967/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 10:51 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-xml
> 
> 
> Description
> -------
> 
> ATM kdev-xml crashes when you start KDevelop. The crash is at xmlcatalog/oasiscatalog.cpp:286
> It tries to assign the value of the PreferPublic static attribute that has not been initialized yet.
> 
> Fix this by post-poning the CatalogManager initialization by moving it in the self() method.
> 
> 
> Diffs
> -----
> 
>   xmlcatalog/icatalogmanager.cpp ee79dbaec715d5b2323917ccdde3c48c8e07686a 
> 
> Diff: http://git.reviewboard.kde.org/r/113967/diff/
> 
> 
> Testing
> -------
> 
> Doesn't crash anymore
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20131120/27d2c984/attachment.html>