Review Request 110295: Preserve relative paths in unresolved include assistant

Commit Hook null at kde.org
Fri May 31 09:10:35 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110295/
-----------------------------------------------------------

(Updated May 31, 2013, 9:10 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.


Description
-------

Preserve relative paths in unresolved include assistant

The unresolved include assistant include relative paths which are
resolved from the storage directory. However, when reopening the
assistant, all relative paths would be turned into absolute ones. Fix
this by converting relative paths in a dedicated method of
CustomIncludePathsSettings and use this one in places where absolute
paths are desirable, leaving the assistant with the original relative
paths for editing.


Diffs
-----

  languages/cpp/includepathresolver.h f0dc530cb162445c5a83b6bd4bbe7249dc3474fe 
  languages/cpp/includepathresolver.cpp 94a4e0bf81df7d93ac296272084a756ae8631acf 

Diff: http://git.reviewboard.kde.org/r/110295/diff/


Testing
-------

Tested behavior on a project with relative custom include paths.


Thanks,

Alexandre Courbot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130531/1bc86a69/attachment.html>


More information about the KDevelop-devel mailing list