Review Request 110295: Preserve relative paths in unresolved include assistant

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110295/#review33501
-----------------------------------------------------------


This review has been submitted with commit bb3dcf3353df40f9736b468b5895fd306d533354 by Alexandre Courbot to branch master.

- Commit Hook


On May 4, 2013, 9:17 a.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110295/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 9:17 a.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.
> 
> 
> Description
> -------
> 
> Preserve relative paths in unresolved include assistant
> 
> The unresolved include assistant include relative paths which are
> resolved from the storage directory. However, when reopening the
> assistant, all relative paths would be turned into absolute ones. Fix
> this by converting relative paths in a dedicated method of
> CustomIncludePathsSettings and use this one in places where absolute
> paths are desirable, leaving the assistant with the original relative
> paths for editing.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/includepathresolver.h f0dc530cb162445c5a83b6bd4bbe7249dc3474fe 
>   languages/cpp/includepathresolver.cpp 94a4e0bf81df7d93ac296272084a756ae8631acf 
> 
> Diff: http://git.reviewboard.kde.org/r/110295/diff/
> 
> 
> Testing
> -------
> 
> Tested behavior on a project with relative custom include paths.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130531/432e505a/attachment.html>