Review Request 110713: Show a status bar if VI mode is enabled

[Sven Brauch]

> On May 29, 2013, 8:10 p.m., Andreas Pakulat wrote:
> > shell/textdocument.cpp, line 793
> > <http://git.reviewboard.kde.org/r/110713/diff/2/?file=146917#file146917line793>
> >
> >     Did you see adymo's comment about there being some status-bar-space at the right end of the bottom button's? I'm not sure that'll look good/right, but maybe worth a try.
> 
> Sven Brauch wrote:
>     Sorry, I don't know what you're referring to here. Which comment do you mean?
> 
> Andreas Pakulat wrote:
>     He replied on the mailinglist thread where we talked about the position of the vi-mode label. See http://mail.kde.org/pipermail/kdevelop-devel/2013-May/045402.html
> 
> Sven Brauch wrote:
>     I guess this corner is meant? http://i.imgur.com/0bxH0bi.png
>     That is not going to work in my opinion, since the information displayed is per-view, and you might have multiple views. On the other hand, we're just displaying the line number for the active view anyways (probably not a good idea either)...
>     Still, it sounds like introducing trouble to me.
> 
> Aleix Pol Gonzalez wrote:
>     I think he meant the top-right corner, where the line and column are.

I think he didn't, he said "bottom right corner, same row as the tool buttons" and there's no tool buttons in the top right corner :)
Anyways, as said on the mailing list I really dislike the idea (speaking of the top right corner), as most people have tabs enabled, and it'll take even more space away from the tab bar. And adding a special case for when the tab bar is disabled ... well, that's a special case which only affects setups which use vi mode and have tabs disabled, which seems to be a rather tiny subgroup to me.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110713/#review33376
-----------------------------------------------------------


On May 30, 2013, 10:42 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110713/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 10:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The kate people recently merged the vi mode status bar into the main editor status bar (which makes sense). We don't show that bar though, so the vi mode bar is missing. This patch adds it back in, by adding a custom label to the view which displays the vi mode and file name. See the thread [1] where this was discussed on kwrite-devel.
> I'm aware that this is not the most elegant code ever but it gets the job done.
> 
> ______
> [1] http://lists.kde.org/?l=kwrite-devel&m=136499004230520&w=2
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt e9cf31f 
>   shell/testeditvimode.cpp PRE-CREATION 
>   shell/textdocument.h 1d31ad9 
>   shell/textdocument.cpp 196dfaf 
> 
> Diff: http://git.reviewboard.kde.org/r/110713/diff/
> 
> 
> Testing
> -------
> 
> seems to work ok, toggling vi mode, toggling mode inside vi mode (insert / normal etc) works
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130530/1ae8f3ab/attachment-0001.html>