<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110713/">http://git.reviewboard.kde.org/r/110713/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 29th, 2013, 8:10 p.m. UTC, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110713/diff/2/?file=146917#file146917line793" style="color: black; font-weight: bold; text-decoration: underline;">shell/textdocument.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">791</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="o">!</span> <span class="n">d</span><span class="o">-></span><span class="n">statusLabel</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you see adymo's comment about there being some status-bar-space at the right end of the bottom button's? I'm not sure that'll look good/right, but maybe worth a try.</pre>
</blockquote>
<p>On May 29th, 2013, 9:43 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I don't know what you're referring to here. Which comment do you mean?</pre>
</blockquote>
<p>On May 30th, 2013, 7:28 a.m. UTC, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">He replied on the mailinglist thread where we talked about the position of the vi-mode label. See http://mail.kde.org/pipermail/kdevelop-devel/2013-May/045402.html</pre>
</blockquote>
<p>On May 30th, 2013, 10:20 a.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess this corner is meant? http://i.imgur.com/0bxH0bi.png
That is not going to work in my opinion, since the information displayed is per-view, and you might have multiple views. On the other hand, we're just displaying the line number for the active view anyways (probably not a good idea either)...
Still, it sounds like introducing trouble to me.</pre>
</blockquote>
<p>On May 30th, 2013, 10:21 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think he meant the top-right corner, where the line and column are.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think he didn't, he said "bottom right corner, same row as the tool buttons" and there's no tool buttons in the top right corner :)
Anyways, as said on the mailing list I really dislike the idea (speaking of the top right corner), as most people have tabs enabled, and it'll take even more space away from the tab bar. And adding a special case for when the tab bar is disabled ... well, that's a special case which only affects setups which use vi mode and have tabs disabled, which seems to be a rather tiny subgroup to me.
</pre>
<br />
<p>- Sven</p>
<br />
<p>On May 30th, 2013, 10:42 a.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated May 30, 2013, 10:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The kate people recently merged the vi mode status bar into the main editor status bar (which makes sense). We don't show that bar though, so the vi mode bar is missing. This patch adds it back in, by adding a custom label to the view which displays the vi mode and file name. See the thread [1] where this was discussed on kwrite-devel.
I'm aware that this is not the most elegant code ever but it gets the job done.
______
[1] http://lists.kde.org/?l=kwrite-devel&m=136499004230520&w=2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems to work ok, toggling vi mode, toggling mode inside vi mode (insert / normal etc) works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/CMakeLists.txt <span style="color: grey">(e9cf31f)</span></li>
<li>shell/testeditvimode.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/textdocument.h <span style="color: grey">(1d31ad9)</span></li>
<li>shell/textdocument.cpp <span style="color: grey">(196dfaf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110713/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>