Review Request 110713: Show a status bar if VI mode is enabled

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110713/#review33376
-----------------------------------------------------------



shell/textdocument.h
<http://git.reviewboard.kde.org/r/110713/#comment24686>

    Since the class already has a d-pointer, you could use Q_PRIVATE_SLOT to have the slot there and avoid the binary incompatibility.
    
    Otherwise you should increase the plugin version, since this change is binary incompatible and hence plugins need to be rebuilt.



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/110713/#comment24687>

    Not sure you want to dive into this, but one could use cmake to try to do a compile-test with the header exposing the enum and a short snippet that uses the enum. If the compile-test succeeds the cmake code can set a define and else not set it so this code could be also enabled for people building kate+kte from git.
    
    I think there already is a config.h.in or so which has such defines in the kdevplatform root.



shell/textdocument.cpp
<http://git.reviewboard.kde.org/r/110713/#comment24688>

    Did you see adymo's comment about there being some status-bar-space at the right end of the bottom button's? I'm not sure that'll look good/right, but maybe worth a try.


- Andreas Pakulat


On May 29, 2013, 6:25 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110713/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 6:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The kate people recently merged the vi mode status bar into the main editor status bar (which makes sense). We don't show that bar though, so the vi mode bar is missing. This patch adds it back in, by adding a custom label to the view which displays the vi mode and file name. See the thread [1] where this was discussed on kwrite-devel.
> I'm aware that this is not the most elegant code ever but it gets the job done.
> 
> ______
> [1] http://lists.kde.org/?l=kwrite-devel&m=136499004230520&w=2
> 
> 
> Diffs
> -----
> 
>   shell/textdocument.h 1d31ad9 
>   shell/textdocument.cpp 196dfaf 
> 
> Diff: http://git.reviewboard.kde.org/r/110713/diff/
> 
> 
> Testing
> -------
> 
> seems to work ok, toggling vi mode, toggling mode inside vi mode (insert / normal etc) works
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130529/aefb15e6/attachment.html>