Review Request 110713: Show a status bar if VI mode is enabled

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110713/
-----------------------------------------------------------

(Updated May 29, 2013, 6:25 p.m.)


Review request for KDevelop.


Changes
-------

add an #ifdef to avoid compile errors (due to new enum value) with kdelibs <= 4.11
Is this the correct way to do that?


Description
-------

The kate people recently merged the vi mode status bar into the main editor status bar (which makes sense). We don't show that bar though, so the vi mode bar is missing. This patch adds it back in, by adding a custom label to the view which displays the vi mode and file name. See the thread [1] where this was discussed on kwrite-devel.
I'm aware that this is not the most elegant code ever but it gets the job done.

______
[1] http://lists.kde.org/?l=kwrite-devel&m=136499004230520&w=2


Diffs (updated)
-----

  shell/textdocument.h 1d31ad9 
  shell/textdocument.cpp 196dfaf 

Diff: http://git.reviewboard.kde.org/r/110713/diff/


Testing
-------

seems to work ok, toggling vi mode, toggling mode inside vi mode (insert / normal etc) works


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130529/4ae7cb6f/attachment.html>