Review Request 109197: do not offer to update signature of signal implementation

Rolf Eike Beer kde at opensource.sf-tec.de
Wed May 22 18:26:34 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109197/
-----------------------------------------------------------

(Updated May 22, 2013, 6:26 p.m.)


Status
------

This change has been discarded.


Review request for KDevelop.


Description
-------

This doesn't make any sense for a signal even if it would be technically possible to change the moc file because whatever is in the moc file will be overwritten when the moc binary regenerates the file.


This addresses bug 315167.
    http://bugs.kde.org/show_bug.cgi?id=315167


Diffs
-----

  languages/cpp/codegen/signatureassistant.cpp 3fd68b4 

Diff: http://git.reviewboard.kde.org/r/109197/diff/


Testing
-------

Compiles, but doesn't work. The assistant tooltop still shows up.


Thanks,

Rolf Eike Beer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130522/a8cc6f22/attachment.html>


More information about the KDevelop-devel mailing list