Review Request 109197: do not offer to update signature of signal implementation

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109197/#review32955
-----------------------------------------------------------


I'd vote for shipping this, the bug can be reproduced on master.

- Kevin Funk


On Feb. 28, 2013, 5 p.m., Rolf Eike Beer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109197/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 5 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This doesn't make any sense for a signal even if it would be technically possible to change the moc file because whatever is in the moc file will be overwritten when the moc binary regenerates the file.
> 
> 
> This addresses bug 315167.
>     http://bugs.kde.org/show_bug.cgi?id=315167
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/signatureassistant.cpp 3fd68b4 
> 
> Diff: http://git.reviewboard.kde.org/r/109197/diff/
> 
> 
> Testing
> -------
> 
> Compiles, but doesn't work. The assistant tooltop still shows up.
> 
> 
> Thanks,
> 
> Rolf Eike Beer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130522/a3b16492/attachment-0001.html>