Review Request 110586: EditorIntegrator changes workarounds

[Vyacheslav Blinov]

> On May 21, 2013, 8:58 p.m., Aleix Pol Gonzalez wrote:
> > parser/java.g, line 90
> > <http://git.reviewboard.kde.org/r/110586/diff/1/?file=145741#file145741line90>
> >
> >     Seems like you need to add the kdevelop-pg-qt to cmake... It's usually better in weird (kdev-pg-qt installed in a different prefix as kdelibs).
> >     
> >     I'd suggest you to go on with this and we can review further when kdev-java is in a releasable state.

Hm, kdevelop-pg-qt stuff is in cmake... And whole installation of up to date kdelibs done in same prefix.
Looks like cmake project misses some tune-up.


On May 21, 2013, 8:58 p.m., Vyacheslav Blinov wrote:
> > I'm really unsure about the rest, maybe david, milian or sven will have a better idea.
> > In any case I'd suggest you to just keep going. Do you have commit access?

No I don't have commit access.


- Vyacheslav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110586/#review32928
-----------------------------------------------------------


On May 21, 2013, 8:46 p.m., Vyacheslav Blinov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110586/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 8:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I did some changes, mostly to satisfy compiler. Not sure if that will work, but at least it can be compiled further.
> 
> Whole readFromDisk stuff removed cause it wont compile and looks quite messy.
> 
> 
> Diffs
> -----
> 
>   duchain/contextbuilder.h 656a067 
>   duchain/contextbuilder.cpp 8a0cf8f 
>   parsejob.cpp e379c7e 
>   parser/java.g f5b1978 
> 
> Diff: http://git.reviewboard.kde.org/r/110586/diff/
> 
> 
> Testing
> -------
> 
> It compiles now
> 
> 
> Thanks,
> 
> Vyacheslav Blinov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130521/95646c61/attachment.html>