Review Request 110586: EditorIntegrator changes workarounds

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110586/#review32928
-----------------------------------------------------------

Ship it!



parsejob.cpp
<http://git.reviewboard.kde.org/r/110586/#comment24411>

    Yes that's messy and it can be done much better.



parser/java.g
<http://git.reviewboard.kde.org/r/110586/#comment24410>

    Seems like you need to add the kdevelop-pg-qt to cmake... It's usually better in weird (kdev-pg-qt installed in a different prefix as kdelibs).
    
    I'd suggest you to go on with this and we can review further when kdev-java is in a releasable state.


I'm really unsure about the rest, maybe david, milian or sven will have a better idea.
In any case I'd suggest you to just keep going. Do you have commit access?

- Aleix Pol Gonzalez


On May 21, 2013, 8:46 p.m., Vyacheslav Blinov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110586/
> -----------------------------------------------------------
> 
> (Updated May 21, 2013, 8:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I did some changes, mostly to satisfy compiler. Not sure if that will work, but at least it can be compiled further.
> 
> Whole readFromDisk stuff removed cause it wont compile and looks quite messy.
> 
> 
> Diffs
> -----
> 
>   duchain/contextbuilder.h 656a067 
>   duchain/contextbuilder.cpp 8a0cf8f 
>   parsejob.cpp e379c7e 
>   parser/java.g f5b1978 
> 
> Diff: http://git.reviewboard.kde.org/r/110586/diff/
> 
> 
> Testing
> -------
> 
> It compiles now
> 
> 
> Thanks,
> 
> Vyacheslav Blinov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130521/884be108/attachment-0001.html>