Review Request 110298: added kdevplatform part of kdevelop zsh integration

[Phil Schaf]

> On May 4, 2013, 9:05 p.m., Andreas Pakulat wrote:
> > util/CMakeLists.txt, line 51
> > <http://git.reviewboard.kde.org/r/110298/diff/2/?file=142029#file142029line51>
> >
> >     Please avoid unrelated whitespace changes.
> >     
> >     What might make sense though if the permissions and destination are the same for these files is to have just a single install() call with all of the files.
> 
> Phil Schaf wrote:
>     that’s what i’m thinking, too, but i don’t know enough about cmake to do it: could you just post that single install call here, as so i can include it without breaking anything accidentally?

i just tried something; could you please verify that this is correct?


- Phil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110298/#review32038
-----------------------------------------------------------


On May 5, 2013, 1:53 p.m., Phil Schaf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110298/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 1:53 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> added kdevplatform part of kdevelop zsh integration
> 
> sister review of https://git.reviewboard.kde.org/r/110299/
> 
> 
> Diffs
> -----
> 
>   util/.zshrc PRE-CREATION 
>   util/CMakeLists.txt 29de12617b4e9d7697abc73465ed435b9039c531 
>   util/kdevplatform_shell_environment.sh d2ece7f9286f8cb8ae35c672a29d5248e2c1a199 
> 
> Diff: http://git.reviewboard.kde.org/r/110298/diff/
> 
> 
> Testing
> -------
> 
> I don’t know if $OLD_ZDOTDIR gets carried over to “kdevplatform_shell_environment.sh” through “.zshrc”!
> 
> can someone help here?
> 
> 
> Thanks,
> 
> Phil Schaf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130505/c32eb70c/attachment.html>