<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110298/">http://git.reviewboard.kde.org/r/110298/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 4th, 2013, 9:05 p.m. UTC, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110298/diff/2/?file=142029#file142029line51" style="color: black; font-weight: bold; text-decoration: underline;">util/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span> <span class="s">FILES</span> <span class="s">kdev_format_source.sh</span> <span class="s">DESTINATION</span> <span class="s">bin</span> <span class="s">PERMISSIONS</span> <span class="s">OWNER_EXECUTE</span> <span class="s">OWNER_WRITE</span> <span class="s">OWNER_READ</span> <span class="s">GROUP_EXECUTE</span> <span class="s">GROUP_READ</span> <span class="s">WORLD_EXECUTE</span> <span class="s">WORLD_READ</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">install</span><span class="p">(</span> <span class="s">FILES</span> <span class="s">kdev_format_source.sh</span> <span class="s">DESTINATION</span> <span class="s">bin</span> <span class="s">PERMISSIONS</span> <span class="s">OWNER_EXECUTE</span> <span class="s">OWNER_WRITE</span> <span class="s">OWNER_READ</span> <span class="s">GROUP_EXECUTE</span> <span class="s">GROUP_READ</span> <span class="s">WORLD_EXECUTE</span> <span class="s">WORLD_READ</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please avoid unrelated whitespace changes.
What might make sense though if the permissions and destination are the same for these files is to have just a single install() call with all of the files.</pre>
</blockquote>
<p>On May 5th, 2013, 12:34 p.m. UTC, <b>Phil Schaf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that’s what i’m thinking, too, but i don’t know enough about cmake to do it: could you just post that single install call here, as so i can include it without breaking anything accidentally?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i just tried something; could you please verify that this is correct?</pre>
<br />
<p>- Phil</p>
<br />
<p>On May 5th, 2013, 1:53 p.m. UTC, Phil Schaf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Phil Schaf.</div>
<p style="color: grey;"><i>Updated May 5, 2013, 1:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">added kdevplatform part of kdevelop zsh integration
sister review of https://git.reviewboard.kde.org/r/110299/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don’t know if $OLD_ZDOTDIR gets carried over to “kdevplatform_shell_environment.sh” through “.zshrc”!
can someone help here?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>util/.zshrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>util/CMakeLists.txt <span style="color: grey">(29de12617b4e9d7697abc73465ed435b9039c531)</span></li>
<li>util/kdevplatform_shell_environment.sh <span style="color: grey">(d2ece7f9286f8cb8ae35c672a29d5248e2c1a199)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110298/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>