Review Request 109547: Annotation toggle behaviour

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109547/#review29988
-----------------------------------------------------------


I have now reverted this change as it breaks the action text when working on multiple documents or closing the annotation border via the annotation border's context menu. Please fix this and implement this feature properly. Alternatively, rename the action to always read "Toggle annotation...".

- Milian Wolff


On March 19, 2013, 5:47 p.m., Przemek Czekaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109547/
> -----------------------------------------------------------
> 
> (Updated March 19, 2013, 5:47 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Those patch, add functionality as toggle for KAction "Annotation" in KDevelop.
> 
> 
> Diffs
> -----
> 
>   vcs/vcspluginhelper.cpp 10e3b53 
> 
> Diff: http://git.reviewboard.kde.org/r/109547/diff/
> 
> 
> Testing
> -------
> 
> Manualy check, click on "Annotation" in Git KAction, then Annotation bar will show, next time when you click on this KAction, Annotation bar will hide self. Before this patch, Annotation bar, close and reopen self again.
> 
> 
> Thanks,
> 
> Przemek Czekaj
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130328/a9f42228/attachment.html>