Review Request 109612: Splashscreen part 2: give startup progress information

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109612/#review29606
-----------------------------------------------------------



shell/core.h
<http://git.reviewboard.kde.org/r/109612/#comment22083>

    Why is there still the setter and this uneeded indirection?
    
    If the signal is to be emitted from the private class, simply make the private a friend of core and give it the Core instance (usually in Qt-based code this is a 'q' member). Then the private class can do emit q->startupProgress(20). There should be examples of this elsewhere in our codebase already I hope.


- Andreas Pakulat


On March 20, 2013, 8:37 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109612/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 8:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This belongs to https://git.reviewboard.kde.org/r/109610/.
> It emits a few (~10) signals from the kdev core when it's starting up, which can then be caught by the splash screen to display a progress bar.
> 
> 
> Diffs
> -----
> 
>   shell/core.h d7ba435 
>   shell/core.cpp 91a5630 
> 
> Diff: http://git.reviewboard.kde.org/r/109612/diff/
> 
> 
> Testing
> -------
> 
> I don't see what could go wrong here.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130321/578b8055/attachment.html>