Review Request 109612: Splashscreen part 2: give startup progress information

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109612/
-----------------------------------------------------------

(Updated March 20, 2013, 8:37 p.m.)


Review request for KDevelop.


Changes
-------

You're right of course. The reason I did it like this was that I forgot about how Qt signals work. The problem I was trying to solve was that the splashscreen class is in kdevelop, but needs to be messaged from kdevplatform. Thus I thought I'd be clever and (slightly) abuse the KSplashScreen (not KDevSplashScreen) showMessage() signal for that purpose -- which has those color and whatever arguments and also the string instead of and int. This is not necessary due to the runtime signature of Qt connections. My mistake -- I fixed it.


Description
-------

This belongs to https://git.reviewboard.kde.org/r/109610/.
It emits a few (~10) signals from the kdev core when it's starting up, which can then be caught by the splash screen to display a progress bar.


Diffs (updated)
-----

  shell/core.h d7ba435 
  shell/core.cpp 91a5630 

Diff: http://git.reviewboard.kde.org/r/109612/diff/


Testing
-------

I don't see what could go wrong here.


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130320/f89099a0/attachment-0001.html>