Review Request 109562: When a user has ( in the project name, use an alternative

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109562/
-----------------------------------------------------------

(Updated March 19, 2013, 1:13 a.m.)


Review request for KDevelop.


Changes
-------

New version of the patch, in this case using a custom QItemDelegate sporting QTextDocument. Now we can show the branch name using italic. yay.

Problems (with the offered implementation):
- styling of the delegate has to be sorted out. It's easy to fix, so only TODO.
- placing of the text has to be sorted out, the text seems to be 1px too low, for some reason.
- QTextDocument doesn't support ellipsis. We can use QFontMetrics for that, but it looks bad when there's rich text.

I can spend more time and fix the first 2. I am unsure about the 3rd, I think it's an important one.


Description
-------

If there's ( in the project name, use [.

Then it will look like "Project Name (some thing) [master]".


Diffs (updated)
-----

  plugins/projectmanagerview/CMakeLists.txt 93971e2 
  plugins/projectmanagerview/projectmodelitemdelegate.h PRE-CREATION 
  plugins/projectmanagerview/projectmodelitemdelegate.cpp PRE-CREATION 
  plugins/projectmanagerview/projecttreeview.cpp 4f9b5ae 
  plugins/projectmanagerview/vcsoverlayproxymodel.cpp b414868 

Diff: http://git.reviewboard.kde.org/r/109562/diff/


Testing
-------


File Attachments (updated)
----------------

Result
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/18/kdevelop-peoplehaveparenthesisinprojectnames.png
custom delegate
  http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/kdevelop-peoplehaveparenthesisinprojectnames1.png


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130319/da6e5129/attachment.html>