Review Request 109562: When a user has ( in the project name, use an alternative

Aleix Pol Gonzalez aleixpol at
Tue Mar 19 01:13:06 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated March 19, 2013, 1:13 a.m.)

Review request for KDevelop.


New version of the patch, in this case using a custom QItemDelegate sporting QTextDocument. Now we can show the branch name using italic. yay.

Problems (with the offered implementation):
- styling of the delegate has to be sorted out. It's easy to fix, so only TODO.
- placing of the text has to be sorted out, the text seems to be 1px too low, for some reason.
- QTextDocument doesn't support ellipsis. We can use QFontMetrics for that, but it looks bad when there's rich text.

I can spend more time and fix the first 2. I am unsure about the 3rd, I think it's an important one.


If there's ( in the project name, use [.

Then it will look like "Project Name (some thing) [master]".

Diffs (updated)

  plugins/projectmanagerview/CMakeLists.txt 93971e2 
  plugins/projectmanagerview/projectmodelitemdelegate.h PRE-CREATION 
  plugins/projectmanagerview/projectmodelitemdelegate.cpp PRE-CREATION 
  plugins/projectmanagerview/projecttreeview.cpp 4f9b5ae 
  plugins/projectmanagerview/vcsoverlayproxymodel.cpp b414868 



File Attachments (updated)

custom delegate


Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list