<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109562/">http://git.reviewboard.kde.org/r/109562/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated March 19, 2013, 1:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New version of the patch, in this case using a custom QItemDelegate sporting QTextDocument. Now we can show the branch name using italic. yay.
Problems (with the offered implementation):
- styling of the delegate has to be sorted out. It's easy to fix, so only TODO.
- placing of the text has to be sorted out, the text seems to be 1px too low, for some reason.
- QTextDocument doesn't support ellipsis. We can use QFontMetrics for that, but it looks bad when there's rich text.
I can spend more time and fix the first 2. I am unsure about the 3rd, I think it's an important one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If there's ( in the project name, use [.
Then it will look like "Project Name (some thing) [master]".</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/CMakeLists.txt <span style="color: grey">(93971e2)</span></li>
<li>plugins/projectmanagerview/projectmodelitemdelegate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectmanagerview/projectmodelitemdelegate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/projectmanagerview/projecttreeview.cpp <span style="color: grey">(4f9b5ae)</span></li>
<li>plugins/projectmanagerview/vcsoverlayproxymodel.cpp <span style="color: grey">(b414868)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109562/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/03/18/kdevelop-peoplehaveparenthesisinprojectnames.png">Result</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/03/19/kdevelop-peoplehaveparenthesisinprojectnames1.png">custom delegate</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>