Review Request 109569: Target compile definitions may have values.

Ben Wagner bungeman at
Mon Mar 18 19:17:02 UTC 2013

This is an automatically generated e-mail. To reply, visit:

(Updated March 18, 2013, 7:17 p.m.)

Review request for KDevelop.


The documentation at states that COMPILE_DEFINITIONS is a list of VAR or VAR=value. When COMPILE_DEFINITIONS is set on a target, KDevelop currently only handles the 'VAR' case, but in the 'VAR=value' case makes the name of the define 'VAR=value' and sets the value to ''. This fixes that.


  projectmanagers/cmake/cmakemodelitems.cpp 3665ac4 



Built and ran, now the correct defines show in pop-ups and the correct code is parsed for editing.


Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list