Review Request 109569: Target compile definitions may have values.

Ben Wagner bungeman at gmail.com
Mon Mar 18 19:16:33 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109569/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

The documentation at http://www.cmake.org/cmake/help/v2.8.8/cmake.html#prop_dir:COMPILE_DEFINITIONS states that COMPILE_DEFINITIONS is a list of VAR or VAR=value. When COMPILE_DEFINITIONS is set on a target, KDevelop currently only handles the 'VAR' case, but in the 'VAR=value' case makes the name of the define 'VAR=value' and sets the value to ''. This fixes that.


Diffs
-----

  projectmanagers/cmake/cmakemodelitems.cpp 3665ac4 

Diff: http://git.reviewboard.kde.org/r/109569/diff/


Testing
-------

Built and ran, now the correct defines show in pop-ups and the correct code is parsed for editing.


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130318/f455822c/attachment.html>


More information about the KDevelop-devel mailing list