OutputModel::flushLineBuffer

[Milian Wolff]

On Thursday 14 February 2013 01:13:43 Aleix Pol wrote:
> On Wed, Feb 13, 2013 at 11:15 PM, Milian Wolff <mail at milianw.de> wrote:
> > Hey Aleix,
> > 
> > what did you intend to fix with OutputModel::flushLineBuffer?
> > 
> > Why was this required? It looks very wrong to me as it breaks the whole
> > batching idea (and was also removed because of this in our
> > wip/filter_output_threaded branch).
> > 
> > I can only see it being used in the CTestRunJob but without any comment
> > indicating *why* its being used there.
> > 
> > Cheers
> > --
> > Milian Wolff
> > mail at milianw.de
> > http://milianw.de
> > _______________________________________________
> > KDevelop-devel mailing list
> > KDevelop-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/kdevelop-devel
> 
> IIRC, flush was only used when the execution arrived to the end and we
> wanted everything to get back to the model. Aparently this got unused
> eventually and then ctest decided to use it.
> 
> Please remove it.

Done, thanks for the clarification.

Cheers
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130317/508af4e6/attachment-0001.sig>