OutputModel::flushLineBuffer

[Milian Wolff]

On Thursday 14 February 2013 01:17:08 Aleix Pol wrote:
> On Wed, Feb 13, 2013 at 11:19 PM, Milian Wolff <mail at milianw.de> wrote:
> > On Wednesday 13 February 2013 23:15:39 Milian Wolff wrote:
> > > Hey Aleix,
> > > 
> > > what did you intend to fix with OutputModel::flushLineBuffer?
> > > 
> > > Why was this required? It looks very wrong to me as it breaks the whole
> > > batching idea (and was also removed because of this in our
> > > wip/filter_output_threaded branch).
> > > 
> > > I can only see it being used in the CTestRunJob but without any comment
> > > indicating *why* its being used there.
> > 
> > Also removeLastLines - why is that required there? To quote Andreas:
> >     Removes 'removeLastLines' since the only user was the ninja-plugin and
> > 
> > that
> > 
> >     one should handle its special needs in its own code instead of
> > 
> > requiring
> > 
> >     API changes that nobody else needs.
> >     
> >     Removes 'flushLineBuffer' since the idea of that function goes
> > 
> > completely
> > 
> >     against the idea of doing batches in the first place so it shouldn't
> > 
> > exist.
> > 
> >     If code needs to know when all items are available in the model it'll
> > 
> > have
> > 
> >     to connect to the model signals and verify wether the number of lines
> > 
> > in
> > 
> >     the model matches the expected final amount. This function is used in
> > 
> > the
> > 
> >     ctest-related code in kdevelop, so will need a change there too.
> > 
> > --
> > Milian Wolff
> > mail at milianw.de
> > http://milianw.de
> > 
> > _______________________________________________
> > KDevelop-devel mailing list
> > KDevelop-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/kdevelop-devel
> 
> We use removeLastLines in the ninja plugin because we optimize the output
> by only showing the last building item in the output model, thus not
> creating a huge list of lines saying: "building blah".
> 
> If it helps the rest of the implementation, please remove the API and I'll
> figure out what to do with that feature. Only please remove the call in
> kdev-ninja so I can keep compiling the plugin meanwhile.

Done. You might be able to implement this using a custom filter proxy model I 
think.

Cheers
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130317/7d29fcb5/attachment.sig>