Review Request 111135: Handle return cmake statement

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111135/#review34714
-----------------------------------------------------------

Ship it!


I'll proceed to push it. Thanks for looking into this!

- Aleix Pol Gonzalez


On June 19, 2013, 6 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111135/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 6 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Handle return statement when walking throuth a function or macro. Recursive cmake macro using return to stop recursion leads to segfault due to stackoverflow in Kdevelop without proper support of this keyword.
> 
> Fixes crash from the bug https://bugs.kde.org/show_bug.cgi?id=320875
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.h cc314fd 
>   projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 5299b7c 
> 
> Diff: http://git.reviewboard.kde.org/r/111135/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> File Attachments
> ----------------
> 
> Formatted patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/19/0002-Support-return-statement.patch
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130619/98852c18/attachment.html>