Review Request 111135: Handle return cmake statement
Sergey Vidyuk
sir.vestnik at gmail.com
Wed Jun 19 18:00:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111135/
-----------------------------------------------------------
(Updated June 19, 2013, 6 p.m.)
Review request for KDevelop.
Changes
-------
added patch created with git format-patch
Description
-------
Handle return statement when walking throuth a function or macro. Recursive cmake macro using return to stop recursion leads to segfault due to stackoverflow in Kdevelop without proper support of this keyword.
Fixes crash from the bug https://bugs.kde.org/show_bug.cgi?id=320875
Diffs
-----
projectmanagers/cmake/parser/cmakeprojectvisitor.h cc314fd
projectmanagers/cmake/parser/cmakeprojectvisitor.cpp 5299b7c
Diff: http://git.reviewboard.kde.org/r/111135/diff/
Testing
-------
Manually tested
File Attachments (updated)
----------------
Formatted patch
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/19/0002-Support-return-statement.patch
Thanks,
Sergey Vidyuk
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130619/0c1e9b0a/attachment.html>
More information about the KDevelop-devel
mailing list