Review Request 111007: kdevelop: expand macro does not work correctly when the arguments are split over multiple lines

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111007/#review34326
-----------------------------------------------------------


Maybe you can put that test in a unit test? Maybe "test_sourcemanipulation.cpp"?

- Aleix Pol Gonzalez


On June 13, 2013, 9:08 p.m., Hannes Hofer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111007/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 9:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> when a macro is used that requires arguments and those arguments are split over multiple lines kdevelop is not able to expand the macro.
> the expander respects only the current line and therefore the parser does not find the corresponding close brace.
> in this fix the next line is added to the argument list until the close brace is found or EOF is reached.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cpplanguagesupport.cpp e2ff0f1 
> 
> Diff: http://git.reviewboard.kde.org/r/111007/diff/
> 
> 
> Testing
> -------
> 
> tested with included simple test file.
> 
> 
> File Attachments
> ----------------
> 
> testmacro
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/13/simplemacro.cpp
> 
> 
> Thanks,
> 
> Hannes Hofer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130613/2d455b3c/attachment.html>