Review Request 111007: kdevelop: expand macro does not work correctly when the arguments are split over multiple lines

Hannes Hofer Hannes.Hofer at gmail.com
Thu Jun 13 21:08:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111007/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

when a macro is used that requires arguments and those arguments are split over multiple lines kdevelop is not able to expand the macro.
the expander respects only the current line and therefore the parser does not find the corresponding close brace.
in this fix the next line is added to the argument list until the close brace is found or EOF is reached.


Diffs
-----

  languages/cpp/cpplanguagesupport.cpp e2ff0f1 

Diff: http://git.reviewboard.kde.org/r/111007/diff/


Testing
-------

tested with included simple test file.


File Attachments
----------------

testmacro
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/13/simplemacro.cpp


Thanks,

Hannes Hofer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130613/1f6a2e80/attachment.html>


More information about the KDevelop-devel mailing list