Review Request 110778: Check Whether the Project is Under VCS Before Asking for Current Branch

[David Narváez]

> On June 2, 2013, 11:09 p.m., Aleix Pol Gonzalez wrote:
> > Hi,
> > I'm sorry, but I fear that this patch shouldn't be necessary. Here you're using the version control system of the project with the same project. It's implicit that the project will be supported. This is ensured by Project::loadVersionControlPlugin().
> > 
> > Am I missing anything?

You are right. I assume that the situation explained in review 11079 caused my SVN project to be marked as a Git project so the wrong plugin was being loaded. I fixed that manually and no longer see this issue.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110778/#review33597
-----------------------------------------------------------


On June 3, 2013, 4:51 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110778/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 4:51 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Currently the proxy model asks a loaded plugin if it is a branching VCS and if so, then asks for the current branch without checking if the current project is actually under that VCS.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/vcsoverlayproxymodel.cpp 9a6708f 
> 
> Diff: http://git.reviewboard.kde.org/r/110778/diff/
> 
> 
> Testing
> -------
> 
> 1. Load a KDevelop session with SVN and Git projects
> 
> Before this patch, KDevelop woul try to run git rev-parse --abbrev-ref HEAD in all projects and an error would pop up in the VCS view for SVN projects. After this patch that doesn't happen for SVN projects and does happen for Git projects.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130603/553affc6/attachment.html>