Review Request 110778: Check Whether the Project is Under VCS Before Asking for Current Branch

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110778/
-----------------------------------------------------------

(Updated June 3, 2013, 4:51 a.m.)


Status
------

This change has been discarded.


Review request for KDevelop.


Description
-------

Currently the proxy model asks a loaded plugin if it is a branching VCS and if so, then asks for the current branch without checking if the current project is actually under that VCS.


Diffs
-----

  plugins/projectmanagerview/vcsoverlayproxymodel.cpp 9a6708f 

Diff: http://git.reviewboard.kde.org/r/110778/diff/


Testing
-------

1. Load a KDevelop session with SVN and Git projects

Before this patch, KDevelop woul try to run git rev-parse --abbrev-ref HEAD in all projects and an error would pop up in the VCS view for SVN projects. After this patch that doesn't happen for SVN projects and does happen for Git projects.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130603/fa9832aa/attachment.html>