Review Request 111815: Quick open plugin: Hide vertical scrollbar instead of disabling it.

[Andreas Pakulat]

> On July 31, 2013, 2:53 p.m., Andreas Pakulat wrote:
> > Does the original commit disabling the scrollbar say why this was done? I just realized I never noticed its disabled (usually I type until only 2 or 3 entries are left anyway), but since moving with the keyboard works maybe the scrollbar should be enabled to allow to scroll?
> 
> Vlas Puhov wrote:
>       Here is the original commit message: "Disable the vertical scroll bar if there is too many items in the quickopen list. Some items in the list are expanded dynamically into multiple items, which makes huge jump in the list very problematic, and can lock up the GUI for a long time in such a case."
>       Also I've tried to enable the scrollbar: fast scrolling really hangs the GUI for a couple of seconds.

I see. Well, one thing the visible but disabled scrollbar is useful for is identifiying that there are more matches than initially visible. Thats something you'd loose when hiding it, I'm a bit undecided which is weighing heavier here though. Especially since for me it always seems to be the case that the last item is cut-off, i.e. the popup does not end at an item boundary and thus its clearly visible that there's more there. Lets see what the others say.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111815/#review36872
-----------------------------------------------------------


On July 31, 2013, 2:07 p.m., Vlas Puhov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111815/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 2:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> When there is too many items in the list the scrollbar is disabled. It looks very odd(I've never seen a disabled scrollbar before). Furthermore it's not so obvious that it's disabled(I figured it out only from the third try).
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/quickopenplugin.h 6de4bd0 
>   plugins/quickopen/quickopenplugin.cpp 3fe08af 
> 
> Diff: http://git.reviewboard.kde.org/r/111815/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vlas Puhov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130731/95c1455a/attachment.html>