<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111815/">http://git.reviewboard.kde.org/r/111815/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 31st, 2013, 2:53 p.m. UTC, <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does the original commit disabling the scrollbar say why this was done? I just realized I never noticed its disabled (usually I type until only 2 or 3 entries are left anyway), but since moving with the keyboard works maybe the scrollbar should be enabled to allow to scroll?</pre>
</blockquote>
<p>On July 31st, 2013, 3:34 p.m. UTC, <b>Vlas Puhov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Here is the original commit message: "Disable the vertical scroll bar if there is too many items in the quickopen list. Some items in the list are expanded dynamically into multiple items, which makes huge jump in the list very problematic, and can lock up the GUI for a long time in such a case."
Also I've tried to enable the scrollbar: fast scrolling really hangs the GUI for a couple of seconds.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see. Well, one thing the visible but disabled scrollbar is useful for is identifiying that there are more matches than initially visible. Thats something you'd loose when hiding it, I'm a bit undecided which is weighing heavier here though. Especially since for me it always seems to be the case that the last item is cut-off, i.e. the popup does not end at an item boundary and thus its clearly visible that there's more there. Lets see what the others say.</pre>
<br />
<p>- Andreas</p>
<br />
<p>On July 31st, 2013, 2:07 p.m. UTC, Vlas Puhov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Vlas Puhov.</div>
<p style="color: grey;"><i>Updated July 31, 2013, 2:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When there is too many items in the list the scrollbar is disabled. It looks very odd(I've never seen a disabled scrollbar before). Furthermore it's not so obvious that it's disabled(I figured it out only from the third try).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/quickopen/quickopenplugin.h <span style="color: grey">(6de4bd0)</span></li>
<li>plugins/quickopen/quickopenplugin.cpp <span style="color: grey">(3fe08af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111815/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>