Review Request 111547: Add support for PHP 5.5's array literal dereferencing.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111547/#review36086
-----------------------------------------------------------

Ship it!


Just remove the obsolete code, then +1 for shipping it.


duchain/expressionvisitor.cpp
<http://git.reviewboard.kde.org/r/111547/#comment26738>

    this is not doing anything anymore, just remove it please


- Milian Wolff


On July 17, 2013, 2:07 p.m., Heinz Wiesinger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111547/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 2:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Add support for PHP 5.5's array literal dereferencing.
> 
> This would for example look like this:
> 
> $a = [1,2,3][0];
> 
> where $a = 1;
> 
> The rfc detailing the feature can be found here: https://wiki.php.net/rfc/constdereference
> 
> I had to rewrite the array handling a little bit to make the typing work as expected and adjusted the unit tests for that as well.
> 
> 
> Diffs
> -----
> 
>   duchain/expressionvisitor.h 3b951fbe878e8a9bd0d8c981a9c2f8c02bfcbc8f 
>   duchain/expressionvisitor.cpp 0a926167eeb5e493f22ac62704865ad6461b64d8 
>   duchain/tests/expressionparser.h a749e973d11505d94abf1ea43d45513ca22d5244 
>   duchain/tests/expressionparser.cpp 72970fce85153fdb1baf97163c306a0e6c312d6c 
>   parser/php.g 55b7b64de919137b03331569381dee45cdb21fb2 
> 
> Diff: http://git.reviewboard.kde.org/r/111547/diff/
> 
> 
> Testing
> -------
> 
> Unit tests and php example code
> 
> 
> Thanks,
> 
> Heinz Wiesinger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130717/bf34250c/attachment-0001.html>