<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111547/">http://git.reviewboard.kde.org/r/111547/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just remove the obsolete code, then +1 for shipping it.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111547/diff/1/?file=171172#file171172line206" style="color: black; font-weight: bold; text-decoration: underline;">duchain/expressionvisitor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ExpressionVisitor::visitVarExpressionNormal(VarExpressionNormalAst *node)</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">200</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">ExpressionVisitor</span><span class="o">::</span><span class="n">visitVarExpressionNormal</span><span class="p">(</span><span class="n">VarExpressionNormalAst</span> <span class="o">*</span><span class="n">node</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">206</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">ExpressionVisitor</span><span class="o">::</span><span class="n">visitVarExpressionNormal</span><span class="p">(</span><span class="n">VarExpressionNormalAst</span> <span class="o">*</span><span class="n">node</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is not doing anything anymore, just remove it please</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On July 17th, 2013, 2:07 p.m. UTC, Heinz Wiesinger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Heinz Wiesinger.</div>
<p style="color: grey;"><i>Updated July 17, 2013, 2:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for PHP 5.5's array literal dereferencing.
This would for example look like this:
$a = [1,2,3][0];
where $a = 1;
The rfc detailing the feature can be found here: https://wiki.php.net/rfc/constdereference
I had to rewrite the array handling a little bit to make the typing work as expected and adjusted the unit tests for that as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests and php example code</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/expressionvisitor.h <span style="color: grey">(3b951fbe878e8a9bd0d8c981a9c2f8c02bfcbc8f)</span></li>
<li>duchain/expressionvisitor.cpp <span style="color: grey">(0a926167eeb5e493f22ac62704865ad6461b64d8)</span></li>
<li>duchain/tests/expressionparser.h <span style="color: grey">(a749e973d11505d94abf1ea43d45513ca22d5244)</span></li>
<li>duchain/tests/expressionparser.cpp <span style="color: grey">(72970fce85153fdb1baf97163c306a0e6c312d6c)</span></li>
<li>parser/php.g <span style="color: grey">(55b7b64de919137b03331569381dee45cdb21fb2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111547/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>