Review Request 111537: Hide empty folders after filtering

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111537/#review36067
-----------------------------------------------------------



project/projectproxymodel.h
<http://git.reviewboard.kde.org/r/111537/#comment26727>

    remove the whitespace in front of the open brace



project/projectproxymodel.cpp
<http://git.reviewboard.kde.org/r/111537/#comment26730>

    Some kind of caching would be a good idea here I bet. This way this function will be called N times on every items for N being the depth of the item in the project tree. That doesn't sound good...
    
    You could just store something like a QHash<ProjectBaseItem*, bool> and clear it when the base model gets changed and/or when the filter changes.



project/projectproxymodel.cpp
<http://git.reviewboard.kde.org/r/111537/#comment26729>

    please put the open brace on the next line


- Milian Wolff


On July 16, 2013, 7:29 p.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111537/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 7:29 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Now when using the filter bar in the projects panel, the folders that contain no items matching the filter are hidden, so you don't have to manually search through all the folders to see if there are items or not. I know this is slower than the previous code, however I tried this on a big project (Qt) and the  impact on performance was unnoticeable.
> 
> 
> Diffs
> -----
> 
>   project/projectproxymodel.h df4e040 
>   project/projectproxymodel.cpp 5da4f6c 
> 
> Diff: http://git.reviewboard.kde.org/r/111537/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130716/6a8ebf81/attachment.html>