Review Request 111537: Hide empty folders after filtering

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jul 16 22:52:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111537/#review36060
-----------------------------------------------------------

Ship it!



project/projectproxymodel.cpp
<http://git.reviewboard.kde.org/r/111537/#comment26711>

    bool ret = <condition>;


Let's do this!

- Aleix Pol Gonzalez


On July 16, 2013, 7:29 p.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111537/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 7:29 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Now when using the filter bar in the projects panel, the folders that contain no items matching the filter are hidden, so you don't have to manually search through all the folders to see if there are items or not. I know this is slower than the previous code, however I tried this on a big project (Qt) and the  impact on performance was unnoticeable.
> 
> 
> Diffs
> -----
> 
>   project/projectproxymodel.h df4e040 
>   project/projectproxymodel.cpp 5da4f6c 
> 
> Diff: http://git.reviewboard.kde.org/r/111537/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130716/a5d73eca/attachment.html>


More information about the KDevelop-devel mailing list