Review Request 111007: kdevelop: expand macro does not work correctly when the arguments are split over multiple lines

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111007/#review36064
-----------------------------------------------------------


nearly there :)

thanks!


languages/cpp/cppduchain/navigation/macronavigationcontext.h
<http://git.reviewboard.kde.org/r/111007/#comment26721>

    also, please move that to the .cpp (you should be able to use the refactoring action to do that basically)



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/111007/#comment26719>

    is the line actually a long? Isn't it int? Also, please remove the whitespace between "lineNumber++" - sorry if I wasn't clear about that coding style ;-)



languages/cpp/cpplanguagesupport.cpp
<http://git.reviewboard.kde.org/r/111007/#comment26720>

    whitespaces around the plus here though please


- Milian Wolff


On July 16, 2013, 9:38 p.m., Hannes Hofer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111007/
> -----------------------------------------------------------
> 
> (Updated July 16, 2013, 9:38 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> when a macro is used that requires arguments and those arguments are split over multiple lines kdevelop is not able to expand the macro.
> the expander respects only the current line and therefore the parser does not find the corresponding close brace.
> in this fix the next line is added to the argument list until the close brace is found or EOF is reached.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/tests/test_cppassistants.cpp 42c7949 
>   languages/cpp/tests/test_cppassistants.h 79fbb99 
>   languages/cpp/cpplanguagesupport.cpp e2ff0f1 
>   languages/cpp/cppduchain/navigation/macronavigationcontext.h eeaa9f6 
> 
> Diff: http://git.reviewboard.kde.org/r/111007/diff/
> 
> 
> Testing
> -------
> 
> unit test included.
> 
> 
> Thanks,
> 
> Hannes Hofer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130716/8d82896e/attachment-0001.html>