Review Request 111007: kdevelop: expand macro does not work correctly when the arguments are split over multiple lines

Hannes Hofer Hannes.Hofer at gmail.com
Tue Jul 16 21:38:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111007/
-----------------------------------------------------------

(Updated July 16, 2013, 9:38 p.m.)


Review request for KDevelop.


Changes
-------

actually there were still some whitespaces in there :)


Description
-------

when a macro is used that requires arguments and those arguments are split over multiple lines kdevelop is not able to expand the macro.
the expander respects only the current line and therefore the parser does not find the corresponding close brace.
in this fix the next line is added to the argument list until the close brace is found or EOF is reached.


Diffs (updated)
-----

  languages/cpp/tests/test_cppassistants.cpp 42c7949 
  languages/cpp/tests/test_cppassistants.h 79fbb99 
  languages/cpp/cpplanguagesupport.cpp e2ff0f1 
  languages/cpp/cppduchain/navigation/macronavigationcontext.h eeaa9f6 

Diff: http://git.reviewboard.kde.org/r/111007/diff/


Testing
-------

unit test included.


Thanks,

Hannes Hofer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130716/9d0ad70b/attachment.html>


More information about the KDevelop-devel mailing list