Review Request 111477: Added the Github plugin to the kdevelop repository.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111477/#review35865
-----------------------------------------------------------

Ship it!



providers/ghprovider/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111477/#comment26559>

    rtrim?



providers/ghprovider/ghaccount.cpp
<http://git.reviewboard.kde.org/r/111477/#comment26560>

    use QString() instead of "".
    
    This way also you don't need to pass the <QString> as well (it's implicit).


Other than those nitpicks, it's fine with me. I think it's a very good thing to have :).

- Aleix Pol Gonzalez


On July 11, 2013, 2:56 p.m., Miquel Sabaté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111477/
> -----------------------------------------------------------
> 
> (Updated July 11, 2013, 2:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> In this review I'm adding the Github plugin that I've been working on in a scratch repo: http://quickgit.kde.org/?p=scratch%2Fmssola%2Fghprovider.git to the KDevelop repository. I've created the "providers" directory again, and I've put in there the KDE Provider plugin and this new Github plugin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8d2f8bb 
>   providers/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/README.md PRE-CREATION 
>   providers/ghprovider/cmake/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/cmake/FindQJson.cmake PRE-CREATION 
>   providers/ghprovider/ghaccount.h PRE-CREATION 
>   providers/ghprovider/ghaccount.cpp PRE-CREATION 
>   providers/ghprovider/ghdialog.h PRE-CREATION 
>   providers/ghprovider/ghdialog.cpp PRE-CREATION 
>   providers/ghprovider/ghlineedit.h PRE-CREATION 
>   providers/ghprovider/ghlineedit.cpp PRE-CREATION 
>   providers/ghprovider/ghprovidermodel.h PRE-CREATION 
>   providers/ghprovider/ghprovidermodel.cpp PRE-CREATION 
>   providers/ghprovider/ghproviderplugin.h PRE-CREATION 
>   providers/ghprovider/ghproviderplugin.cpp PRE-CREATION 
>   providers/ghprovider/ghproviderwidget.h PRE-CREATION 
>   providers/ghprovider/ghproviderwidget.cpp PRE-CREATION 
>   providers/ghprovider/ghresource.h PRE-CREATION 
>   providers/ghprovider/ghresource.cpp PRE-CREATION 
>   providers/ghprovider/icons/CMakeLists.txt PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-github-forked.png PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-github-private.png PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-github-repo.png PRE-CREATION 
>   providers/ghprovider/icons/hi16-app-kdevgh.png PRE-CREATION 
>   providers/ghprovider/icons/hi32-app-kdevgh.png PRE-CREATION 
>   providers/ghprovider/kdevghprovider.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111477/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Miquel Sabaté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130711/7ff9e502/attachment-0001.html>