<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111477/">http://git.reviewboard.kde.org/r/111477/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111477/diff/2/?file=170381#file170381line34" style="color: black; font-weight: bold; text-decoration: underline;">providers/ghprovider/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kdevghprovider</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rtrim?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111477/diff/2/?file=170386#file170386line52" style="color: black; font-weight: bold; text-decoration: underline;">providers/ghprovider/ghaccount.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="o">!</span><span class="n">m_group</span><span class="p">.</span><span class="n">readEntry</span><span class="o"><</span><span class="n">QString</span><span class="o">></span><span class="p">(</span><span class="s">"id"</span><span class="p">,</span> <span class="s">""</span><span class="p">).</span><span class="n">isEmpty</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use QString() instead of "".
This way also you don't need to pass the <QString> as well (it's implicit).</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other than those nitpicks, it's fine with me. I think it's a very good thing to have :).</pre>
<p>- Aleix</p>
<br />
<p>On July 11th, 2013, 2:56 p.m. UTC, Miquel Sabaté wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Miquel Sabaté.</div>
<p style="color: grey;"><i>Updated July 11, 2013, 2:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this review I'm adding the Github plugin that I've been working on in a scratch repo: http://quickgit.kde.org/?p=scratch%2Fmssola%2Fghprovider.git to the KDevelop repository. I've created the "providers" directory again, and I've put in there the KDE Provider plugin and this new Github plugin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(8d2f8bb)</span></li>
<li>providers/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/README.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/cmake/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/cmake/FindQJson.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghaccount.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghaccount.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghlineedit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghlineedit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghprovidermodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghprovidermodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghproviderwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghresource.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/ghresource.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-github-forked.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-github-private.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-github-repo.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi16-app-kdevgh.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/icons/hi32-app-kdevgh.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>providers/ghprovider/kdevghprovider.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111477/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>