Review Request 108690: Use an actual directory as the working dir for the rev-list job.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108690/#review26472
-----------------------------------------------------------

Ship it!


I'd rename the argument to reflect that change then please commit into 1.5 branch


plugins/git/gitplugin.cpp
<http://git.reviewboard.kde.org/r/108690/#comment20124>

    this should then be reflected in the name of the parameter - it's apparently not the repository but now any path.


- Milian Wolff


On Jan. 31, 2013, 8:01 p.m., Eli MacKenzie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108690/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2013, 8:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I was unable to open the Revision Graph, KDevelop would freeze every time. With the freeze fixed, there was still no contents. I found that the git plugin was trying to use the full path to a file as a directory, which of course QDir did not agree was a directory. I was about to implement a method like urlDir, but found QFileInfo was already included... which lead to this simple patch. 
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitplugin.cpp f1f9baf6ff28ec055155e67f7cb0996c11356c22 
> 
> Diff: http://git.reviewboard.kde.org/r/108690/diff/
> 
> 
> Testing
> -------
> 
> I'm able to open the revision graph from the context menu now.
> 
> 
> Thanks,
> 
> Eli MacKenzie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130131/a449bd2e/attachment.html>