Review Request 108690: Use an actual directory as the working dir for the rev-list job.

Eli MacKenzie argonel at gmail.com
Thu Jan 31 20:01:36 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108690/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

I was unable to open the Revision Graph, KDevelop would freeze every time. With the freeze fixed, there was still no contents. I found that the git plugin was trying to use the full path to a file as a directory, which of course QDir did not agree was a directory. I was about to implement a method like urlDir, but found QFileInfo was already included... which lead to this simple patch. 


Diffs
-----

  plugins/git/gitplugin.cpp f1f9baf6ff28ec055155e67f7cb0996c11356c22 

Diff: http://git.reviewboard.kde.org/r/108690/diff/


Testing
-------

I'm able to open the revision graph from the context menu now.


Thanks,

Eli MacKenzie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130131/4092a7e7/attachment.html>


More information about the KDevelop-devel mailing list