Review Request 108654: Make it possible to search and open documentation from QuickOpen

[Aleix Pol Gonzalez]

> On Jan. 30, 2013, 3:06 p.m., Milian Wolff wrote:
> > plugins/quickopen/quickopenplugin.cpp, line 858
> > <http://git.reviewboard.kde.org/r/108654/diff/1/?file=109789#file109789line858>
> >
> >     The scope text looks wrong to me... Maybe we could make it empty and hide the combo box in such a case? I find 'includes' quite confusing and considering that I can't change it anyways - lets try to hide that no?

Yes, we should probably discuss it in the context of the command line. For the moment I'd say that it's ok to leave it like that.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108654/#review26432
-----------------------------------------------------------


On Jan. 29, 2013, 12:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108654/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 12:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Last week I was talking with Alex Fiestas about how hard it is now to open documentation within KDevelop.
> This patch lets the user open the documentation using QuickOpen.
> 
> I moved the Ctrl+Alt+D shortcut to the QuickOpen, instead of showing the documentation toolview directly.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/CMakeLists.txt b15a8fc 
>   plugins/quickopen/documentationquickopenprovider.h PRE-CREATION 
>   plugins/quickopen/documentationquickopenprovider.cpp PRE-CREATION 
>   plugins/quickopen/projectitemquickopen.cpp 08de124 
>   plugins/quickopen/quickopenmodel.cpp 022c7bd 
>   plugins/quickopen/quickopenplugin.h f3dcec2 
>   plugins/quickopen/quickopenplugin.cpp f6f3460 
>   shell/documentationcontroller.cpp ade717c 
> 
> Diff: http://git.reviewboard.kde.org/r/108654/diff/
> 
> 
> Testing
> -------
> 
> For the moment it works fine and it seems useful to me.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/29/kdev-quickopen-docs.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/29/kdev-quickopen-docs1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130131/9ecebaed/attachment.html>