Review Request 108654: Make it possible to search and open documentation from QuickOpen

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108654/#review26432
-----------------------------------------------------------


Excellent idea - a few minor nitpicks then I'm looking forward to this!

But I should really try to work on my "kdevelop command line" idea this year... Having to memorize yet another shortcut for documentation quick open sucks. A single quick open where I could write "documentation <pattern>" would be so neat ;-) Anyhow, this doesn't hold this review request back of course. Just personal ramblings.

Thanks Aleix!


plugins/quickopen/documentationquickopenprovider.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20110>

    whitespaces around operators please (not just in this line...)



plugins/quickopen/documentationquickopenprovider.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20114>

    use .indexOf instead of contains (idx != -1) + startsWith (idx == 0)



plugins/quickopen/documentationquickopenprovider.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20112>

    add braces please



plugins/quickopen/documentationquickopenprovider.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20113>

    put the i++ on its own line please



plugins/quickopen/documentationquickopenprovider.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20111>

    remove debug



plugins/quickopen/projectitemquickopen.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20115>

    unrelated changeset (but looks good - please commit separately)



plugins/quickopen/quickopenmodel.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20116>

    unrelated - remove



plugins/quickopen/quickopenplugin.cpp
<http://git.reviewboard.kde.org/r/108654/#comment20117>

    The scope text looks wrong to me... Maybe we could make it empty and hide the combo box in such a case? I find 'includes' quite confusing and considering that I can't change it anyways - lets try to hide that no?


- Milian Wolff


On Jan. 29, 2013, 12:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108654/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 12:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Last week I was talking with Alex Fiestas about how hard it is now to open documentation within KDevelop.
> This patch lets the user open the documentation using QuickOpen.
> 
> I moved the Ctrl+Alt+D shortcut to the QuickOpen, instead of showing the documentation toolview directly.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/CMakeLists.txt b15a8fc 
>   plugins/quickopen/documentationquickopenprovider.h PRE-CREATION 
>   plugins/quickopen/documentationquickopenprovider.cpp PRE-CREATION 
>   plugins/quickopen/projectitemquickopen.cpp 08de124 
>   plugins/quickopen/quickopenmodel.cpp 022c7bd 
>   plugins/quickopen/quickopenplugin.h f3dcec2 
>   plugins/quickopen/quickopenplugin.cpp f6f3460 
>   shell/documentationcontroller.cpp ade717c 
> 
> Diff: http://git.reviewboard.kde.org/r/108654/diff/
> 
> 
> Testing
> -------
> 
> For the moment it works fine and it seems useful to me.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/29/kdev-quickopen-docs.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/29/kdev-quickopen-docs1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20130130/bf119180/attachment.html>